Update notebook for validation against multiple use cases#449
Merged
JieXiong9119 merged 2 commits intodevelop-v2from Nov 7, 2022
Merged
Update notebook for validation against multiple use cases#449JieXiong9119 merged 2 commits intodevelop-v2from
JieXiong9119 merged 2 commits intodevelop-v2from
Conversation
So now the example could be validated against these use cases: 1. SEED 2. L0 OS Pre-simulation 3. BRICR SEED Plus a few corrections on the example data.
JieXiong9119
added
enhancement
Non-breaking Change
Schema: No Changes
nllong
approved these changes
Aug 23, 2022
Member
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
wow, more use cases are enabled. Nicely done!
| </LinkedPremises> | ||
| </Scenario> | ||
| <Scenario ID="Scenario-POM-LEDs"> | ||
| <ScenarioName>POM-LEDs</ScenarioName> |
Contributor
Author
|
This PR is trying to enrich the example to cover as many use cases as possible, as to prove the generalisability among different use cases. This effort also shows mutual exclusivity between a few use cases. The fundamental use case is L200 Audit. The other three use cases could be validated through adding a few elements:
Invalid use cases:
I suggest we should make effort to address the compatibility between this example and L100 Audit use case in the future as they should be intuitively. |
laurenliz22
approved these changes
Nov 2, 2022
Contributor
laurenliz22
left a comment
laurenliz22
left a comment
There was a problem hiding this comment.
Looks good @JieXiong9119 , thank you for identifying the changes to pass the use cases!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The existing outputs from notebook examples could only be validated against one use case (the corresponding level of audit). There are several use cases that could be satisfied with simple modification to current examples.
What does this PR do?
So now the output example could be validated against these use cases:
SEED, L200 Audit, L000 OS Pre-simulation, BRICR SEED
A few corrections on the example data
How should this be manually tested?
What are the relevant tickets?
BuildingSync/project-tracker#119
Screenshots (if appropriate)