Create Add Equipment ID.md#451
Merged
laurenliz22 merged 2 commits intoBuildingSync:develop-v2from Jan 5, 2023
Merged
Conversation
JieXiong9119
approved these changes
Sep 7, 2022
Contributor
JieXiong9119
left a comment
JieXiong9119
left a comment
There was a problem hiding this comment.
The proposal looks good. I wonder if there is a "more official" way to discover corresponding elements other than tracking 'Manufacturer'.
nllong
approved these changes
Oct 21, 2022
Member
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
looks good. I verified that we are using ObjectID and not ObjectId... so this proposal correct.
This commit implements the proposal by adding the `auc:EquipmentID` child element to the proposed elements.
laurenliz22
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
N/A
What does this PR do?
New proposal to add "Equipment ID" field to the schema.
How should this be manually tested?
No testing required.
What are the relevant tickets?
N/A
Screenshots (if appropriate)