Create Add DiscountRate.md#457
Merged
JieXiong9119 merged 3 commits intoBuildingSync:develop-v2from Jan 5, 2023
Merged
Conversation
Fractional values are rounded up to the nearest integer.
nllong
approved these changes
Oct 21, 2022
| <xs:complexType> | ||
| <xs:simpleContent> | ||
| <xs:extension base="xs:decimal"> | ||
| <xs:extension base="xs:nonNegativeInteger"> |
| </xs:simpleContent> | ||
| </xs:complexType> | ||
| </xs:element> | ||
| <xs:element name="DiscountRate" minOccurs="0"> |
Member
There was a problem hiding this comment.
Nice! And thanks for updating the documentation of the discount factor.
laurenliz22
reviewed
Nov 2, 2022
| $$ NPV\left({i,N}\right) = \sum_{t=0}^{N}{\frac{R_{t}}{\left({1+i}\right)^t}} $$ | ||
|
|
||
| where | ||
| * $i$ is the discount rate (percentage). |
Contributor
There was a problem hiding this comment.
Should we say i is the interest rate here since v is the discount rate where v=1/(1+i)?
laurenliz22
approved these changes
Nov 2, 2022
Contributor
laurenliz22
left a comment
laurenliz22
left a comment
There was a problem hiding this comment.
Looks good, thanks Mark! I had one comment on the definition of i
JieXiong9119
approved these changes
Jan 4, 2023
JieXiong9119
added a commit
to markborkum/schema
that referenced
this pull request
Jan 5, 2023
The recent change in PR BuildingSync#457 requires element `<auc:UsefulLife>` to be `xsd:nonNegativeInteger`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
N/A
What does this PR do?
New proposal to add "Discount Rate" element.
How should this be manually tested?
N/A
What are the relevant tickets?
N/A
Screenshots (if appropriate)