Add PrincipalLightingSystemType#473
Merged
JieXiong9119 merged 3 commits intodevelop-v2from Jun 14, 2023
Merged
Conversation
See proposal
JieXiong9119
added
Schema: General
Contributor
|
@JieXiong9119, The range for the "Principal Lighting System Type" user-defined field:
|
Contributor
Author
Thanks. Would we want to keep "Other" and "Unknown"? |
Contributor
Including them would align with the definitions for other enumerations in the schema. Another design question is whether to include all lighting system types that are present in the schema. |
The combined options might have overlaps (e.g. LED and Solid State Lighting).
markborkum
approved these changes
Jun 1, 2023
Contributor
markborkum
left a comment
markborkum
left a comment
There was a problem hiding this comment.
Looks good. Thanks, @JieXiong9119.
nllong
reviewed
Jun 6, 2023
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
This was referenced Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See proposal
Any background context you want to provide?
What does this PR do?
To add
PrincipalLightingSystemTypeunderBuildingandSectionto enable direct mapping to/from Audit Template Tool, and omit the usage of UDF. However we do not recommend using this element other than AT use case, Instead, in BuildingSync world, we recommend usingSystem/LightingSystems/LightingSystem/LampTypeto specify lighting type and link it to the correpondingBuildingorSectionviaLightingSystem/LinkedPremises.How should this be manually tested?
To do: need to confirm if the enumerations mapped correctly to AT library.
To do: need to make sure the usage of referencing global element is correct.
To do: test for schema and example validity.
What are the relevant tickets?
#470
#466