Skip to content

Change PrincipalHVACSystemType #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JieXiong9119 merged 3 commits into from
Jun 14, 2023
Merged

Change PrincipalHVACSystemType #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2b5b98
Create proposal and implementation
JieXiong9119 Jun 2, 2023
9ba56cf
Update proposals/2023/Update PrincipalHVACSystemType.md
JieXiong9119 Jun 14, 2023
0df248e
Merge branch 'develop-v2' into feat/change-principal-hvac-system-type
JieXiong9119 Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions BuildingSync.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@
</xs:sequence>
</xs:complexType>
</xs:element>
<xs:element ref="auc:PrincipalHVACSystemType" minOccurs="0"/>
<xs:element ref="auc:YearOfConstruction" minOccurs="0"/>
<xs:element ref="auc:PrincipalLightingSystemType" minOccurs="0"/>
<xs:element name="YearOccupied" type="xs:gYear" minOccurs="0">
Expand Down Expand Up @@ -960,6 +961,7 @@
<xs:element ref="auc:SpatialUnits" minOccurs="0"/>
<xs:element ref="auc:PrimaryContactID" minOccurs="0"/>
<xs:element ref="auc:TenantIDs" minOccurs="0" maxOccurs="unbounded"/>
<xs:element ref="auc:PrincipalHVACSystemType" minOccurs="0"/>
<xs:element ref="auc:PrincipalLightingSystemType" minOccurs="0"/>
<xs:element ref="auc:YearOfConstruction" minOccurs="0"/>
<xs:element name="FootprintShape" minOccurs="0">
Expand Down Expand Up @@ -5597,32 +5599,7 @@
</xs:restriction>
</xs:simpleType>
</xs:element>
<xs:element name="PrincipalHVACSystemType" minOccurs="0">
<xs:annotation>
<xs:documentation>Principal HVAC type.</xs:documentation>
</xs:annotation>
<xs:simpleType>
<xs:restriction base="xs:string">
<xs:enumeration value="Packaged Terminal Air Conditioner"/>
<xs:enumeration value="Four Pipe Fan Coil Unit"/>
<xs:enumeration value="Packaged Terminal Heat Pump"/>
<xs:enumeration value="Packaged Rooftop Air Conditioner"/>
<xs:enumeration value="Packaged Rooftop Heat Pump"/>
<xs:enumeration value="Packaged Rooftop VAV with Hot Water Reheat"/>
<xs:enumeration value="Packaged Rooftop VAV with Electric Reheat"/>
<xs:enumeration value="VAV with Hot Water Reheat"/>
<xs:enumeration value="VAV with Electric Reheat"/>
<xs:enumeration value="Warm Air Furnace"/>
<xs:enumeration value="Ventilation Only"/>
<xs:enumeration value="Dedicated Outdoor Air System"/>
<xs:enumeration value="Water Loop Heat Pump"/>
<xs:enumeration value="Ground Source Heat Pump"/>
<xs:enumeration value="VRF Terminal Unit"/>
<xs:enumeration value="Chilled Beam"/>
<xs:enumeration value="Other"/>
</xs:restriction>
</xs:simpleType>
</xs:element>
<xs:element ref="auc:PrincipalHVACSystemType" minOccurs="0"/>
</xs:choice>
<xs:element name="HVACControlSystemTypes" minOccurs="0">
<xs:annotation>
Expand Down Expand Up @@ -6863,6 +6840,33 @@
<xs:attribute name="ID" type="xs:ID" use="required"/>
<xs:attribute ref="auc:Status"/>
</xs:complexType>
<xs:element name="PrincipalHVACSystemType">
<xs:annotation>
<xs:documentation>Principal HVAC type.</xs:documentation>
</xs:annotation>
<xs:simpleType>
<xs:restriction base="xs:string">
<xs:enumeration value="Packaged Terminal Air Conditioner"/>
<xs:enumeration value="Four Pipe Fan Coil Unit"/>
<xs:enumeration value="Packaged Terminal Heat Pump"/>
<xs:enumeration value="Packaged Rooftop Air Conditioner"/>
<xs:enumeration value="Packaged Rooftop Heat Pump"/>
<xs:enumeration value="Packaged Rooftop VAV with Hot Water Reheat"/>
<xs:enumeration value="Packaged Rooftop VAV with Electric Reheat"/>
<xs:enumeration value="VAV with Hot Water Reheat"/>
<xs:enumeration value="VAV with Electric Reheat"/>
<xs:enumeration value="Warm Air Furnace"/>
<xs:enumeration value="Ventilation Only"/>
<xs:enumeration value="Dedicated Outdoor Air System"/>
<xs:enumeration value="Water Loop Heat Pump"/>
<xs:enumeration value="Ground Source Heat Pump"/>
<xs:enumeration value="VRF Terminal Unit"/>
<xs:enumeration value="Chilled Beam"/>
<xs:enumeration value="Other"/>
<xs:enumeration value="Unknown"/>
</xs:restriction>
</xs:simpleType>
</xs:element>
<xs:complexType name="LightingSystemType">
<xs:sequence>
<xs:element name="LampType" minOccurs="0">
Expand Down
17 changes: 17 additions & 0 deletions proposals/2023/Update PrincipalHVACSystemType.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Update PrincipalHVACSystemType

## Overview

This proposal is to update the usage of element `auc:PrincipalHVACSystemType` to be defined under the `auc:Building` and `auc:Section` elements.

## Justification

The Audit Template Tool requires this element living directly under building and section level instead of being referred through `auc:LinkedPremises` with `auc:HVACSystem/auc:PrincipalHVACSystemType`.

## Implementation
Change the definition of element `auc:PrincipalLightingSystemType` globally, and refer it under `auc:Building` and `auc:Section`, as well as `auc:HVACSystem` (where we have the element currently).

## Decision
We add this element to avoid the usage of UDF for a commonly used element in AT and improve the data transferability between AT and BuildingSync. However we don't recommend the usage of this element under `auc:Building` and `auc:Section` other than the use case of input/output to/from Audit Template.

## References