Add FacilityEvaluationAuditDefinition

[JieXiong9119]

Any background context you want to provide?

FEMP CERL use case

What does this PR do?

See proposal

How should this be manually tested?

What are the relevant tickets?

#466

Screenshots (if appropriate)

[markborkum]

@JieXiong9119, Since the FEMP document is still a draft, it may be too early to add this new XML element to the schema.

For example, if the FEMP document changes, since the proposal is to introduce a 2-level hierarchical structure, moving a level-2 child to a different level-1 parent would be a breaking change.

[JieXiong9119]

Another way to modify on this is to create two layers of elements:

• auc:FacilityEvaluationAuditDefinition
  -- auc:OnsiteAudit
  --- auc:Basic
  ---- enums
  --- auc:Detailed
  ---- enums
  -- auc:RemoteAudit
  --- auc:Basic
  ---- enums
  --- auc:Detailed
  ---- enums

[markborkum]

@JieXiong9119, I'm not convinced that adding a hierarchy is going to add value. Having a "plain" enumeration would be easier to maintain.

[JieXiong9119]

That's reasonable. We can hold it off a bit. Do you have any idea when the FEMP resource would be finalized?

[markborkum]

@JieXiong9119,

Do you have any idea when the FEMP resource would be finalized?

I don't, sorry. We'd need to ask a FEMP representative. I know that an updated version of the "decision tree" document was recently published (https://www.energy.gov/femp/articles/femp-facility-evaluation-audit-decision-tree), but I don't know if it is the final version that we should be targeting.

[ThibaultMarzullo]

It all looks good. One question: why is retrocommissioning under the Detailed Onsite Audit category? In the FEMP draft, it is in the Related Energy and Water Assessment Activities section.

[markborkum]

@ThibaultMarzullo, Adding "Retro-Commissioning Audit" (non-BEDES spelling) was requested by CERL.

In Audit Template, the enumerations were sourced from https://www.energy.gov/sites/default/files/2020/12/f81/facility-evaluation-definitions.pdf which appears to be an earlier (out-of-date?) draft of the FEMP guidance.

[ThibaultMarzullo]

@ThibaultMarzullo, Adding "Retro-Commissioning Audit" (non-BEDES spelling) was requested by CERL.

Thank you! I'll approve then.

In Audit Template, the enumerations were sourced from https://www.energy.gov/sites/default/files/2020/12/f81/facility-evaluation-definitions.pdf which appears to be an earlier (out-of-date?) draft of the FEMP guidance.

Are there any major changes you have noticed? Is there anything that will cause inconsistencies if we use the most recent version?

[markborkum]

@ThibaultMarzullo, Comparing https://www.energy.gov/sites/default/files/2020/12/f81/facility-evaluation-definitions.pdf and https://www.energy.gov/femp/articles/femp-facility-evaluation-audit-definitions, I don't see any new/modified audit definitions. That said, it is possible that the second link is also outdated. We should ask a FEMP representative for the most recent version.

[JieXiong9119]

@markborkum, after circling around FEMP and PNNL teams, the document is confirmed to be the latest version. We will proceed to merge this down if you see no other issues.

[markborkum]

@JieXiong9119, No issues from me, thanks!