Skip to content

Add WCMs to existing categories#481

Merged
JieXiong9119 merged 4 commits intodevelop-v2from
feat/add-wcms-to-existing-categories
Aug 21, 2023
Merged

Add WCMs to existing categories#481
JieXiong9119 merged 4 commits intodevelop-v2from
feat/add-wcms-to-existing-categories

Conversation

@JieXiong9119
Copy link
Copy Markdown
Contributor

Any background context you want to provide?

BuildingSync is adding water conservation measures (WCMs) into its measure library. Based on iterations of discussion and edits on the list of WCM categories and measure names in here, several new categories are proposed with associated measures, and other measures are distributed to existing corresponding BuildingSync measure categories.

What does this PR do?

This PR is to add the new measures to existing BuildingSync measure categories.

How should this be manually tested?

What are the relevant tickets?

#165

Screenshots (if appropriate)

@JieXiong9119 JieXiong9119 added enhancement Schema: Measures Update to measures Non-breaking Change feature Adding new functionality to BuildingSync labels Aug 3, 2023
@JieXiong9119 JieXiong9119 self-assigned this Aug 3, 2023
Copy link
Copy Markdown
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JieXiong9119 JieXiong9119 changed the title Feat/add wcms to existing categories Add WCMs to existing categories Aug 15, 2023
Copy link
Copy Markdown
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JieXiong9119 JieXiong9119 merged commit da7d5fd into develop-v2 Aug 21, 2023
@JieXiong9119 JieXiong9119 deleted the feat/add-wcms-to-existing-categories branch August 21, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature Adding new functionality to BuildingSync Non-breaking Change Schema: Measures Update to measures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants