Add fenestration system measures#492
Merged
JieXiong9119 merged 6 commits intodevelop-v2from Sep 23, 2024
Merged
Conversation
draft names
JieXiong9119
added
Schema: Measures
Contributor
Author
|
Please hold yourr review before we get feedbacks from Measure Naming expert. |
markborkum
approved these changes
Jul 25, 2024
Contributor
markborkum
left a comment
markborkum
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks, Jie!
Contributor
ThibaultMarzullo
left a comment
ThibaultMarzullo
left a comment
There was a problem hiding this comment.
Thanks Jie, this looks good! I reviewed this and will hold until after we received feedback on measure names. Can you reach out to the PNNL team that has suggested the measures and invite them to review this PR please? I'd like to keep them in the loop in case they want to comment before we implement changes.
ThibaultMarzullo
approved these changes
Sep 11, 2024
Contributor
Author
|
We did not hear back from 1836-RP team, so we'll use the instruction in "Best Practices for Measure Names: Lessons from 1836-RP" (previously for WCMs review) for measure naming guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
See #490 .
What does this PR do?
See proposal.
How should this be manually tested?
What are the relevant tickets?
#490
Screenshots (if appropriate)