Search functionality and few bug fixes#156
Merged
opticod merged 9 commits intoBuildmLearn:bug-fixesfrom Sep 3, 2016
tejavojjala:master
Merged
Search functionality and few bug fixes#156opticod merged 9 commits intoBuildmLearn:bug-fixesfrom tejavojjala:master
opticod merged 9 commits intoBuildmLearn:bug-fixesfrom
tejavojjala:master
Conversation
added 9 commits
August 26, 2016 21:19
# The first commit's message is: fixed app crash in phones with api level<19 # This is the 2nd commit message: fixed app crash in phones with api level<19
setting adapter before adding views results in app crash in few versions of android
Collaborator
|
Can you mention the list of bugs fixed by this PR? @iit2014086 |
Collaborator
|
🎉 LGTM merging. Small note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed are one due to objects.equals and other is becoz of adding header view after the adapter is set in mainfragment of matchtemplate it's making the app crash.
Apart from these after i added search functionality a few bugs came in but i resolved those now.