Multiselection bug solved#195
Merged
opticod merged 1 commit intoBuildmLearn:bug-fixesfrom Nov 12, 2016
codingblazer:multiselect_bug
Merged
Multiselection bug solved#195opticod merged 1 commit intoBuildmLearn:bug-fixesfrom codingblazer:multiselect_bug
opticod merged 1 commit intoBuildmLearn:bug-fixesfrom
codingblazer:multiselect_bug
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#142 #162 #163 #164
Hey @opticod , please review the PR.
Overview - The bug was because -Earlier, the code below was to update SelectedPosition because everytime element is deleted from arraylist, indices of elements changes. But this will fail if user make deletion operation more than once.
To solve this bug, I have sorted the arraylist in reverse order which solves the problem in efficient way and is standard way of handling such cases (Removing multiple elements from arraylist).
Also , in SaveApkFragment the deleted elements were not removed from the selectedPositions Map after the deletion operation.Thanks.