Add interceptCheckpointUpdates to TieringStatusIT and TierCancelIT#228
Merged
Bukhtawar merged 1 commit intoMay 20, 2026
Conversation
Fixes ReplicationTracker assertion race condition (opensearch-project#3923) by adding MockTransportService interceptor to gracefully handle checkpoint updates during relocation handoff. Removes @AwaitsFix as the root cause is now addressed. Signed-off-by: Kavya Aggarwal <kavyaagg@amazon.com>
Bukhtawar
approved these changes
May 20, 2026
Bukhtawar
merged commit 8120c36
into
Bukhtawar:improve/native-memory-admission-control
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
interceptCheckpointUpdatesfix toTieringStatusITandTierCancelITto resolve theReplicationTrackerassertion race condition (GitHub opensearch-project#3923).During tiering operations with segment replication, a checkpoint update can arrive after relocation handoff begins, triggering an assertion in
ReplicationTracker.updateVisibleCheckpointForShard. The fix intercepts theUPDATE_VISIBLE_CHECKPOINTtransport action and gracefully handles theAssertionError— the same approach already applied toHotToWarmTieringServiceITandWarmToHotTieringServiceIT.This PR is intended to be merged into opensearch-project#21749.
Related Issues
Resolves the flaky
TieringStatusIT.testTieringStatusfailure (muted via@AwaitsFixin opensearch-project#21749 commit 7).Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.