Remove hardcoded port ENV var from Dockerfile#26
Merged
jthomperoo merged 4 commits intomainfrom Apr 1, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/1cdee7dc-da15-4e1b-a3d1-5781290d72b2 Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix config file to set server port properly
Remove hardcoded port/address ENV vars from Dockerfile
Apr 1, 2026
jthomperoo
requested changes
Apr 1, 2026
Member
jthomperoo
left a comment
There was a problem hiding this comment.
This needs a changelog update, noting it's a breaking change.
Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/a2d9f856-8f05-4967-a9ff-0db693f45cbb Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com>
Contributor
Author
Added a breaking change entry to the |
jthomperoo
requested changes
Apr 1, 2026
Member
jthomperoo
left a comment
There was a problem hiding this comment.
Testing this for Docker we still need to bind Address to 0.0.0.0 for Docker
…ort ENV removed Agent-Logs-Url: https://github.com/BusinessSimulations/dev-oidc-toolkit/sessions/caea958e-f1b7-4288-9932-a4fc5c98a0aa Co-authored-by: jthomperoo <6690498+jthomperoo@users.noreply.github.com>
Contributor
Author
Re-added |
Copilot
AI
changed the title
Remove hardcoded port/address ENV vars from Dockerfile
Remove hardcoded port ENV var from Dockerfile
Apr 1, 2026
jthomperoo
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENV DevOidcToolkit__Port=8080in the Dockerfile took precedence overconfig.json, making file-based port configuration silently ignored.Changes
ENV DevOidcToolkit__Port; retainENV DevOidcToolkit__Address=0.0.0.0(required for Docker networking); updateEXPOSEandHEALTHCHECKto port80(the application default)-p 8080:8080→-p 8080:80to reflect the container now listening on port 80 by default"Port"values from8080to80to match the application defaultUsers who need a custom port can now set it via
config.jsonor an explicit-e DevOidcToolkit__Port=...without it being silently overridden.