BTRControl does not respond properly to combined control states

[jwilling]

Setting an image for flags: (BTRControlStateHighlighted | BTRControlStateSelected)

does not work properly when highlighted.

---

I'm unsure about how the logic should be handled here. If we're saying that we only want the image to be set for those flags, then it's doing it correctly. The image will only be shown when both of those flags are matched.

However, if we're looking at it another way where we show the image on both highlighted and selected states, then currently we're doing it wrong.

[CodaFi]

UIControl handles it by ignoring any subsequent values in the bitmask, so I think Butter's controls should work like that.

[indragiek]

I think this should have the issue title edited to reflect the fact that it's not an issue specific to BTRButton but rather to BTRControl overall.

[jwilling]

Done.

[jwilling]

I'm leaning more towards the choice of having the combined states be considered a unique state rather than two (or more) different states. @indragiek, any opinion on that?

In other words, BTRControlStateHighlighted | BTRControlStateSelected would only be hit when the control is both highlighted and selected.

[lbrndnr]

In my opinion, the BTRControlStateHighlighted | BTRControlStateSelected should be handled as one state. However, the control shouldn't fallback to the default content if there's no bitmask matching to the current state. It should find the best matching content. Setting a specific content for BTRControlStateSelected I don't care about BTRControlStateHover so BTRControlStateSelected | BTRControlStateHover should be handled the same as BTRControlStateSelected by itself.

[jwilling]

Works as intended.