Enable precious gitignore syntax through gix#340
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Byron
force-pushed
the
precious-support
branch
2 times, most recently
from
b5bddad to
7f57754
Compare
When opening the Git repository for ignored-entry detection, add a config override gitoxide.parsePrecious=true so precious ignore syntax works out of the box. **Usage** ```gitignore $preciousFile preciousFile disposable ``` Now `preciousFile` won't show up in `dua` for auto-marking, only `disposable` will. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
For simpler code, and nobody needed that anyway. Can be re-introduced if that changes. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
**`gitignore` Configuration Option** A new config option, `gitignore`, now lets users control Git-ignored entry detection in interactive mode. It is defined as an optional boolean in the config (`Option<bool>`), and if left unset it defaults to enabled behavior (same as previous behavior). **Usage** You can control it in your config file as follows: ```toml gitignore = true gitignore = false ``` **Motivation** This makes Git-ignored behavior configurable without requiring feature flags or build-time changes, while preserving existing behavior for users who do not set the option. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Add `cleanup_heuristics` configuration option for interactive mode, to allow turning it off mainly as it default to 'on'. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by Codex GPT-5.
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Reported issue
Remove separate
gix-globandgix-pathcrates and refer to them throughgixdirectly. Also, add a config-override when opening the Git repository togitoxide.parsePrecious=trueto support precious file syntax out of the box.Summary
gix-globandgix-pathdependencies and updated call sites to usegix::globandgix::pathre-exports.gitfeature while makinggixthe single crate dependency for the sharedgixAPIs.gitoxide.parsePrecious=truefor both full and reduced trust levels.$precious.tmpin the existing gitignored-entry journey.Git baseline
The reference Git checkout at
7760f83b59750c27df653c5c46d0f80e44cfe02chas noparsePreciousorignored-and-preciousignore syntax. This behavior is a gitoxide extension parsed bygix-ignorethrough the$prefix.Validation
cargo test --features git gitignored_entries_are_marked_with_dedicated_keycargo fmt --checkcargo check --no-default-featurescargo clippy --workspace --all-targets -- -D warningscargo testwas also run; 49 of 51 main tests passed, with two local fixture graph-size assertions failing due filesystem allocation-size differences unrelated to this change.Review
codex review --commit 39bdf69bdc4b42f6cbfe99a448da265837b3287fcould not complete because the local Codex CLI reported a usage limit. It was not rerun for the same commit hash.