Fix regressions #113
Merged
Fix regressions #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31c9cdf. The role selection does not work, because: - The label is actually called `roles` - The `roles` label is an array, so `=` comparison with a role string does not work - Deployer selector does not support a comparison operator to check if an array contains a value
$task is of type ConfigurableTaskInterface, while $deployerTask is of type Task (from Deployer). Next taskConfig iteration would run `supports` on Deployer Task type, which obviously does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The master branch contains a few regressions:
PHP Fatal error: Uncaught Error: Call to undefined method Deployer\Task\Task::supports() in phar:///bin/hypernode-deploy/src/DeployRunner.php:150