Create Brancher node with provided labels and settings #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes the labels and settings configured in the `deploy.php`, validates the data and passes them on to Hypernode API when creating a Brancher instance. Next step will be the ability to cleanup Brancher instances based on deployment stage and Brancher labels.
AlexanderGrooff
suggested changes
Nov 28, 2022
Validation of brancher labels is now done on the server side, so this doesn't make sense anymore.
AlexanderGrooff
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the labels and settings configured in the
deploy.php, validates the data and passes them on to Hypernode API when creating a Brancher instance.Next step will be the ability to cleanup Brancher instances based on deployment stage and Brancher labels.