Cleanup Brancher nodes by labels #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdgroot
changed the title
tdgroot
changed the title
Comment on lines
57
to
80
| /** @var string $stageName */ | ||
| $stageName = $input->getArgument('stage'); | ||
| if ($stageName) { | ||
| $config = $this->configurationLoader->load( | ||
| $input->getOption('file') ?: 'deploy.php' | ||
| ); | ||
| foreach ($config->getStages() as $stage) { | ||
| if ($stage->getName() !== $stageName) { | ||
| continue; | ||
| } | ||
| foreach ($stage->getServers() as $server) { | ||
| if (!($server instanceof BrancherServer)) { | ||
| continue; | ||
| } | ||
| $labels = $server->getLabels(); | ||
| $hypernode = $server->getOptions()[Server::OPTION_HN_PARENT_APP]; | ||
| $brancherHypernodes = $this->brancherHypernodeManager->queryBrancherHypernodes( | ||
| $hypernode, | ||
| $labels | ||
| ); | ||
| $this->brancherHypernodeManager->cancel(...$brancherHypernodes); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You could refactor it in a method cancelBasedOnLabel or something to keep this method concise
There was a problem hiding this comment.
Good suggestion! Will do
The configuration loading was moved into a separate class and I also removed the |
vdloo
approved these changes
Dec 5, 2022
tdgroot
force-pushed
the
cleanup_by_labels
branch
from
0b837b4 to
37f6d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on and needs to be merged after #65.
This allows brancher nodes to be cleaned up by labels. Hypernode Deploy will look up existing brancher nodes using the API, match them with the labels of the given stage and delete them.
This is an explicit feature, so it is necessary to call
hypernode-deploy cleanup <target>on a specific point of the pipeline configuration (for example after a PR is closed).