Skip to content

Conversation

@Niutah
Copy link
Contributor

@Niutah Niutah commented Dec 12, 2022

before:
image

after:
image

Copy link
Member

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have done this for the note admonition, but have you considered the other admonitions as well? https://myst-parser.readthedocs.io/en/latest/syntax/roles-and-directives.html?highlight=warning#admonitions

@Niutah
Copy link
Contributor Author

Niutah commented Dec 13, 2022

new changes of the header and floating logo,
before:
Screenshot 2022-12-13 111037

after:

Screenshot 2022-12-13 111023

@Niutah
Copy link
Contributor Author

Niutah commented Dec 13, 2022

new changes of the header and button:

before:
Uploading Screenshot 2022-12-13 144235.png…

after:
Screenshot 2022-12-13 144207

also now after clicking on the anchor you see the title of the anchor on the screen still (before it was scrolling too far)

@github-actions
Copy link
Contributor

Acceptance server is available at https://hntestgroot-ephanmxgi.hypernode.io

@tdgroot tdgroot marked this pull request as ready for review December 14, 2022 08:28
@github-actions
Copy link
Contributor

Acceptance server is available at https://hntestgroot-eph3rkj4z.hypernode.io

@Niutah
Copy link
Contributor Author

Niutah commented Dec 14, 2022

I see you have done this for the note admonition, but have you considered the other admonitions as well? https://myst-parser.readthedocs.io/en/latest/syntax/roles-and-directives.html?highlight=warning#admonitions

Good point! Changed and implemented all kind of admonitions :)

@github-actions
Copy link
Contributor

Acceptance server is available at https://hntestgroot-epholhdvk.hypernode.io

@tdgroot tdgroot merged commit 563e7f4 into master Dec 16, 2022
@tdgroot tdgroot deleted the styling-buttons-and-admonition-note branch December 16, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants