Fixed #43: Notification at the time of downloading #61
Conversation
|
@sitamadex11 can you please review this PR |
|
bro I have tested the functionality. Great work but there have been some issues.
|
HeySitam
added
enhancement
Yes bro I also see that issue and trying to resolve that. Sometimes it's working fine but sometimes it lag the loading |
This comment was marked as duplicate.
This comment was marked as duplicate.
app/src/main/java/com/gcect/gcectapp/ui/fragments/HomeFragment.kt
Outdated
Show resolved
Hide resolved
|
|
||
| } | ||
|
|
||
| fun createNotificationChannel() { |
There was a problem hiding this comment.
Creating an extension function will be better choice , So we can reuse this in other fragments also
There was a problem hiding this comment.
Now It's also used in other fragment as I checked.
There was a problem hiding this comment.
never seen this kind of method in an extension function before, we can still use it in different fragments using the class instance?
usually, I've used the extension function for some view utility or activity or some internal class which I don't have access
There was a problem hiding this comment.
Please feel free to share your thoughts on this
There was a problem hiding this comment.
Yaa, I also used this common method on utils but for now according to this issue I have only implement in one place there is an another issue in which I have to implement that functionality where it is required with common method.
This is only for testing the functionality that's it's working.
app/src/main/java/com/gcect/gcectapp/ui/fragments/HomeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/gcect/gcectapp/ui/fragments/HomeFragment.kt
Outdated
Show resolved
Hide resolved
|
@sitamadex11 @logic-cribber now I change it to notify can you please check |
|
@MohitGupta121 overall what's the status? |
Bhaiya I fixed the issue according to @logic-cribber changes requested |
|
Can anyone @sitamadex11 will review this |
|
|
||
| } | ||
|
|
||
| fun createNotificationChannel() { |
There was a problem hiding this comment.
never seen this kind of method in an extension function before, we can still use it in different fragments using the class instance?
usually, I've used the extension function for some view utility or activity or some internal class which I don't have access
|
|
||
| } | ||
|
|
||
| fun createNotificationChannel() { |
There was a problem hiding this comment.
Please feel free to share your thoughts on this
|
@sitamadex11 can you please review it and approve it so that I'll move to the next issue. |
4 participants
Fixed #43 Notification at the time of downloading