Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and user experience of the SpotifyLink application. The main changes involve updating the version number, adjusting timing intervals, removing redundant code, and enhancing the user interface.
Version Update:
pom.xml: Updated the version from1.2.1to1.2.2.Timing Interval Adjustments:
src/main/de.bytephil/authorization/SpotifyAPIConnector.java: Reduced the interval for checking the current track info from 2 seconds to 1 second.src/main/de.bytephil/handlers/SpotifyHandler.java: Reduced the interval for getting the queue as song objects from 3 seconds to 1 second.Code Simplification:
src/main/de.bytephil/main/Main.java: Removed redundant code for handling the username when the song is not playing.User Interface Enhancements:
src/main/resources/WebPages/assets/script/mainpage.js: Added initialization forsongAddedandcountervariables to improve the display message when a song is added.src/main/resources/WebPages/assets/script/mainpage.js: Improved the readability of the message displayed when an incorrect session code is entered.