fix(vapi): bisect round 3 — baseline minimum assistant config#43
Merged
ByteStreams-AI merged 1 commit intomainfrom May 5, 2026
Merged
fix(vapi): bisect round 3 — baseline minimum assistant config#43ByteStreams-AI merged 1 commit intomainfrom
ByteStreams-AI merged 1 commit intomainfrom
Conversation
| // order) still have the expected DB state. The bisect is purely | ||
| // about the RESPONSE shape returned to Vapi, not the function's | ||
| // side effects. | ||
| void vapiShape; |
Contributor
There was a problem hiding this comment.
vapiShape=false path silently returns Vapi shape
void vapiShape discards the parameter and the function now always returns the Vapi-shaped stub regardless of whether the caller used the legacy internal format (top-level call_id/caller_phone/destination_phone). Any caller that previously received { status: 'ok', first_message, prompt, tools, context } will now receive { assistant: { firstMessage: ... } }. None of the current integration tests exercise the legacy path directly (they all go through startCall() which uses the Vapi envelope), so the breakage is invisible to CI — but any curl probe or script relying on the internal format will silently get the wrong shape back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #32
Greptile Summary
This is round-3 of an ongoing bisect (Issue #32) to isolate why Vapi keeps returning "Couldn't get assistant." It strips
handleAssistantRequestdown to the documented minimum — a fixedfirstMessage, a generic GPT-4o-mini system prompt, and a hardcoded Rachel voice — while keeping thevoice_callsupsert and restaurant lookup intact so dependent integration tests retain their expected DB state.vapi_call_start/index.ts: removes all dynamic prompt/tool/customer-lookup logic from the assistant-request handler and returns a hardcoded stub;voiceForRestaurantandTRANSCRIBER_CONFIGare kept but suppressed witheslint-disable no-unused-varsfor the revert.voice.test.ts: the Sui's-Sushi-specific assistant-request test is skipped with a clear comment; all other tests (tool-calls,end-of-call-report,get_menu, etc.) remain active.Confidence Score: 4/5
Safe to merge as a temporary debug stub — the change is intentionally narrow and well-documented, and the revert path is explicit in the code and PR description.
The
void vapiShapediscard is the only non-obvious change: legacy internal-format callers now receive a Vapi-shaped response instead of the internal{ status, first_message, prompt, tools }shape. No integration tests exercise that path directly, so the breakage is invisible to CI.supabase/functions/vapi_call_start/index.ts — specifically the
void vapiShapeline and the silent collapse of both code paths into the same stub responseImportant Files Changed
Reviews (1): Last reviewed commit: "fix(vapi): bisect round 3 — minimum base..." | Re-trigger Greptile