fix(vapi): restore full assistant behavior after bisect#47
Merged
ByteStreams-AI merged 2 commits intomainfrom May 6, 2026
Merged
fix(vapi): restore full assistant behavior after bisect#47ByteStreams-AI merged 2 commits intomainfrom
ByteStreams-AI merged 2 commits intomainfrom
Conversation
Owner
Author
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #32
Restores the full assistant-request behavior after the bisect rounds:
Also records the restore in the developer journal.
Greptile Summary
This PR reverts the two bisect-round commits (Issue #32) and restores the full dynamic
assistant-requesthandler invapi_call_start: prompt rendering, customer lookup, tool selection with Vapi-specserverblocks,endCallPhrases,endCallFunctionEnabled, and the voice/transcriber config. The integration test for Sui's Sushi is re-enabled with the now-correct assertions.functionsfield alongsidetools— the prior concern about dual-path dispatch is resolved.endCallFunctionEnabled: trueand anendCallPhrasesarray (including'goodbye'as the safety-net trigger) are both returned and asserted in the test.callFngeneric in the test declarestoolsasArray<{ name: string }>while the actual wrapped shape nests the name attool.function.name, requiring an inlineas unknown ascast.Confidence Score: 5/5
Safe to merge — the restore cleanly removes the bisect stubs and returns the production assistant config to its pre-bisect state, with the confirmed-safe field set (no
serverMessages, no legacyfunctionsfield).The changed code is a direct revert of two temporary debug commits whose sole purpose was the bisect investigation. The key incident findings (
serverMessagesrejection, dispatcher URL requirement) are already encoded in the comments and test assertions. All three assertions the previous reviewer flagged as missing (endCallFunctionEnabled,endCallPhrases, wrapped-tool shape) are now present.No files require special attention. The only nit is the stale
toolstype annotation in the test generic.Important Files Changed
functionsfield present alongsidetools— the prior concern is resolved in this restore.endCallFunctionEnabledandendCallPhrasesassertions. Thetoolstype in the callFn generic is declared asArray<{ name: string }>but the actual wrapped shape is{ function: { name } }, requiring an inline cast.Reviews (2): Last reviewed commit: "fix(vapi): address PR #47 review comment..." | Re-trigger Greptile