Skip to content

nav: Home opens in same tab + external-URL anchor fix#7

Merged
pratyush618 merged 2 commits intomainfrom
fix/nav-external-links
Apr 19, 2026
Merged

nav: Home opens in same tab + external-URL anchor fix#7
pratyush618 merged 2 commits intomainfrom
fix/nav-external-links

Conversation

@pratyush618
Copy link
Copy Markdown
Contributor

Summary

  • Home nav link now opens in the same tab (dropped external: true on the Home nav entry).
  • External URLs (Home, GitHub) now render as plain <a> instead of Next <Link> — prevents App Router state corruption on back-navigation (symptom: the hero/page renders blank until a hard refresh).
  • New src/lib/url.ts with isExternalUrl() helper; navbar branches on it.

Test plan

  • Click Home in the navbar — opens in same tab, no trailing arrow.
  • Click GitHub in the navbar — still opens in a new tab with the arrow.
  • Click Home, hit browser back — docs portal renders immediately without a manual refresh.
  • Internal anchors (#tools) still scroll-navigate via Next <Link>.

Next Link with external URL corrupts App Router state on back
navigation — page renders blank until refresh. Detect external
URLs via isExternalUrl helper and use a plain <a> instead.
@pratyush618 pratyush618 merged commit f6407d4 into main Apr 19, 2026
6 checks passed
@pratyush618 pratyush618 deleted the fix/nav-external-links branch April 19, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant