feat(dashboard): consume persisted settings#101
Merged
pratyush618 merged 3 commits intomasterfrom May 1, 2026
Merged
Conversation
Renders Open in Grafana / Sentry / OTel buttons when those integration URLs are configured. The {job_id} placeholder is substituted into the template so users can deep-link into pre-filtered dashboards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire up the three settings categories that landed in #99 so the values actually drive the UI:
useBranding()resolves the dashboard title (sidebar header + mobile menu);useApplyAccent()sets the--color-accentCSS variable on<html>and derives--color-accent-dimviacolor-mix()so badges and hover states stay coherent. Invalid colors are silently ignored.dashboard.external_linksis non-empty, rendering each as<a target="_blank" rel="noreferrer noopener">.{job_id}placeholder which is substituted (URL-encoded) when the link is opened.All settings parsing/derivation lives in
features/settings/derived.tsso consumers don't reimplement JSON parsing or null-handling.useSettings()is shared via TanStack Query — first consumer triggers the fetch, everyone else reads from cache.Test plan
pnpm exec biome checkpnpm exec tsc --noEmitpnpm test(34 vitest passed)pnpm build(clean)#6366f1), a link, and Grafana URL with{job_id}— verify all surface correctly and clearing each value reverts to default