fix(ci): set DOCS_BASE_PATH for GH Pages deploy#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #136 made
DOCS_BASE_PATHan explicit env var (replacing theNODE_ENV === "production"heuristic) so localpnpm build && pnpm startserves cleanly at/. The deploy workflow was never updated, so the GH Pages build went out without/taskitoas the basePath — every CSS/JS asset underdocs.byteveda.org/taskito/404s and the live site renders raw unstyled HTML.This passes
DOCS_BASE_PATH=/taskitointo the workflow's build step. CI builds get the deploy basePath; local builds keep their root-mounted preview.Test plan
masterdocs.byteveda.org/taskito/renders with full styling/taskito/_next/...