ci: run postgres + redis test suites with service containers#73
Merged
pratyush618 merged 4 commits intomasterfrom Apr 26, 2026
Merged
ci: run postgres + redis test suites with service containers#73pratyush618 merged 4 commits intomasterfrom
pratyush618 merged 4 commits intomasterfrom
Conversation
serde serializes JobStatus as the variant name ("Pending"/"Running"),
not the #[repr(i32)] discriminant. The Lua dup-check and race-guard
scripts compared against 0/1, so duplicate detection always missed,
the unique key got overwritten, and a fresh job was created.
Surfaced by enabling cargo test --features redis in CI (PR #73).
The Lua scripts in enqueue_unique no longer hardcode the JobStatus variant names. They now receive the active-status values via ARGV sourced from a new `JobStatus::wire_name()` helper — the single source of truth for the Rust→JSON wire contract. A unit test asserts that wire_name() matches what serde actually emits for every variant, so any future serde rename or attribute change breaks the build instead of silently corrupting the Redis duplicate-detection path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-test-postgresandrust-test-redis— that spin uppostgres:16-alpineandredis:7-alpineas service containers and runcargo test --workspace --features <backend>against them.cargo check --features postgres|redissteps from the existingrust-testjob (now covered by the dedicated test jobs).Why
The contract test suite at
crates/taskito-core/tests/rust/storage_tests.rsis already wired to readTASKITO_POSTGRES_TEST_URL/TASKITO_REDIS_TEST_URLand runs the samerun_storage_tests(&storage)block against all three backends. Until now CI only rancargo checkon those features — it compiled, but never executed a single Postgres or Redis test. This closes that gap.Scope
Pure
.github/workflows/ci.ymlchange. Zero code edits.Test plan
rust-test-postgresandrust-test-redisjobs and both go greenrust-test,lint, andtest(Python matrix) jobs continue to pass