refactor: split redis_backend/jobs.rs into submodule#96
Merged
pratyush618 merged 1 commit intomasterfrom May 1, 2026
Merged
Conversation
Move 1199-line jobs.rs into a folder module split by concern: enqueue, dequeue, state, query, maintenance, errors, helpers. Each submodule holds a partial impl block. No behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis_backend/jobs.rs(1199 lines) into aredis_backend/jobs/submoduleimpl RedisStorageblock grouped by concerncrates/taskito-core/src/scheduler/enqueue.rsat 302 linesWhat moved where
jobs/mod.rs— module declarations +dequeue_scorehelper (used by enqueue/retry paths)jobs/enqueue.rs—enqueue,enqueue_batch,enqueue_unique,validate_dep_idsjobs/dequeue.rs—dequeue,dequeue_fromjobs/state.rs—complete,fail,retry,cancel_job,request_cancel,is_cancel_requested,mark_cancelled,cascade_cancel,get_dependencies,get_dependents,update_progressjobs/query.rs—get_job,list_jobs,list_jobs_filtered,stats,count_running_by_task,stats_by_queue,stats_all_queuesjobs/maintenance.rs—purge_completed,purge_completed_with_ttl,reap_stale_jobs,expire_pending_jobs,cancel_pending_by_queue,cancel_pending_by_taskjobs/errors.rs—record_error,get_job_errors,purge_job_errorsjobs/helpers.rs—load_job,get_job_required,save_job_and_move_status,delete_job_fully(private to backend)Test plan
cargo check --workspacecargo check --workspace --features postgrescargo check --workspace --features rediscargo clippy --workspace --features rediscargo test --workspace— all 78 tests passRedisStoragetype