refactor: split py_queue/workflow_ops.rs into submodule#97
Merged
pratyush618 merged 1 commit intomasterfrom May 1, 2026
Merged
refactor: split py_queue/workflow_ops.rs into submodule#97pratyush618 merged 1 commit intomasterfrom
pratyush618 merged 1 commit intomasterfrom
Conversation
Move 1004-line workflow_ops.rs into a folder module split by concern: lifecycle, nodes, fan_out, gates, queries. Each submodule holds a partial #[pymethods] impl block. No behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py_queue/workflow_ops.rs(1004 lines) into apy_queue/workflow_ops/submodule#[pymethods] impl PyQueueblock (enabled by pyo3'smultiple-pymethodsfeature, already in use)lifecycle.rsat 320 linesWhat moved where
workflow_ops/mod.rs— module declarations + shared helpers (workflow_storage,parse_step_metadata,build_metadata_json,status_to_py,cascade_skip_pending_nodes)workflow_ops/lifecycle.rs—submit_workflow,cancel_workflow_run,finalize_run_if_terminalworkflow_ops/nodes.rs—mark_workflow_node_result,set_workflow_node_waiting_approval,set_workflow_node_running,set_workflow_node_fan_out_count,fail_workflow_node,skip_workflow_nodeworkflow_ops/fan_out.rs—expand_fan_out,create_deferred_job,check_fan_out_completionworkflow_ops/gates.rs—resolve_workflow_gateworkflow_ops/queries.rs—get_workflow_run_status,get_base_run_node_data,get_workflow_definition_dagTest plan
cargo check --workspacecargo check --workspace --features postgrescargo check --workspace --features rediscargo check --workspace --features native-asynccargo clippy --workspace --features rediscargo test --workspace— all 78 tests passuv run maturin develop && uv run python -m pytest tests/python/ -v— 465 passed, 9 skipped (workflow tests: 75 passed)