Skip to content

Conversation

@foxmicha
Copy link
Contributor

@foxmicha foxmicha commented Jun 22, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

When an error within the parsing is detected, the stream that started the parsing can be destroyed in some instances. This makes an assumption that users want the file stream destroyed when an error is encountered.

Rather than destroying the stream, pass the error through the regular callback structure.

This resolves #397

Don't make assumptions that users want the file stream destroyed when an error is encountered
@coveralls
Copy link

Pull Request Test Coverage Report for Build 143814964

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 95.986%

Totals Coverage Status
Change from base Build 143471363: 0.09%
Covered Lines: 729
Relevant Lines: 745

💛 - Coveralls

@doug-martin
Copy link
Contributor

@foxmicha thank you for the PR!

I'll look at this sometime today and look at releasing it. I think in older versions of node the destroy was required.

@doug-martin doug-martin merged commit 7769e69 into C2FO:master Jun 23, 2020
@foxmicha foxmicha deleted the patch-1 branch June 23, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] this.destroy is not a function

3 participants