Skip to content

Pass errors through callbacks #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Pass errors through callbacks #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/parse/src/CsvParserStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class CsvParserStream<I extends Row, O extends Row> extends Transform {
const rows = this.parse(newLine, true);
return this.processRows(rows, done);
} catch (e) {
return this.destroy(e);
return done(e);
}
}

Expand Down Expand Up @@ -114,7 +114,7 @@ export class CsvParserStream<I extends Row, O extends Row> extends Transform {
const iterate = (i: number): void => {
const callNext = (err?: Error): void => {
if (err) {
return this.destroy(err);
return cb(err);
}
if (i % 100 === 0) {
// incase the transform are sync insert a next tick to prevent stack overflow
Expand Down