Nationality for MapUnits and adjective for Civilization#881
Closed
stavrosfa wants to merge 4 commits intoC7-Game:Developmentfrom
Closed
Nationality for MapUnits and adjective for Civilization#881stavrosfa wants to merge 4 commits intoC7-Game:Developmentfrom
stavrosfa wants to merge 4 commits intoC7-Game:Developmentfrom
Conversation
… and captured units Added adjective for Civilization Updated some description texts
TomWerner
approved these changes
Feb 14, 2026
Contributor
TomWerner
left a comment
TomWerner
left a comment
There was a problem hiding this comment.
Cool! The captured workers being slower is a nice functionality gap to close
C7Engine/C7GameData/MapUnit.cs
Outdated
| return !this.IsBusy() && this.movementPoints.canMove; | ||
| } | ||
|
|
||
| public bool IsSlave() { |
Contributor
There was a problem hiding this comment.
Maybe IsCaptured? That seems like it generalizes better to artillery and such (and I think is how it's displayed in the military advisor)
Contributor
Author
There was a problem hiding this comment.
How about to IsCaptive ? IsCaptured seems like the logical term, but I associate it with the result of a method, like another unit tried to capture it, and it succeeded, not the state of the unit, if that makes any sense.
Contributor
There was a problem hiding this comment.
IsCaptive sounds great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added property Nationality for MapUnit, distinguishing between native and captured units.
Added adjective for Civilization
Updated some description texts
Another bite size chunk that can be merged by itself, before I open a PR for the capturing units mechanism.