Skip to content

Remove absolute paths from logged standard output#217

Merged
SeanBryan51 merged 1 commit intomainfrom
162-absolute-paths-in-logged-standard-output
Dec 5, 2023
Merged

Remove absolute paths from logged standard output#217
SeanBryan51 merged 1 commit intomainfrom
162-absolute-paths-in-logged-standard-output

Conversation

@SeanBryan51
Copy link
Copy Markdown
Collaborator

@SeanBryan51 SeanBryan51 commented Dec 1, 2023

This change forces paths to be relative to the CWD throughout the code base unless absolute paths are required.

Improves code readability and cleaner logging to standard output.

Fixes #162

@SeanBryan51 SeanBryan51 linked an issue Dec 1, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ab84f0a) 82.68% compared to head (2af76a4) 84.23%.
Report is 5 commits behind head on main.

Files Patch % Lines
benchcab/benchcab.py 0.00% 3 Missing ⚠️
benchcab/fluxsite.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   82.68%   84.23%   +1.54%     
==========================================
  Files          28       28              
  Lines        1496     1484      -12     
==========================================
+ Hits         1237     1250      +13     
+ Misses        259      234      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeanBryan51 SeanBryan51 force-pushed the 162-absolute-paths-in-logged-standard-output branch 7 times, most recently from 3bba6bf to 321c2fd Compare December 3, 2023 23:17
This change forces paths to be relative to the CWD throughout the code
base unless absolute paths are required.

Improves code readability and cleaner logging to standard output.

Fixes #162
@SeanBryan51 SeanBryan51 force-pushed the 162-absolute-paths-in-logged-standard-output branch from 321c2fd to 2af76a4 Compare December 3, 2023 23:22
Copy link
Copy Markdown
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@SeanBryan51 SeanBryan51 merged commit 0d2e415 into main Dec 5, 2023
@SeanBryan51 SeanBryan51 deleted the 162-absolute-paths-in-logged-standard-output branch December 5, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Absolute paths in logged standard output

2 participants