Clean parsing of optional config.yaml data#238
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 58.22% 59.13% +0.90%
==========================================
Files 29 29
Lines 2109 2129 +20
==========================================
+ Hits 1228 1259 +31
+ Misses 881 870 -11 ☔ View full report in Codecov by Sentry. |
c255bf3 to
39049bd
Compare
config.yaml dataconfig.yaml data
ccarouge
left a comment
There was a problem hiding this comment.
A couple of minor changes and some documentation/linting issues to solve.
Re-ask for a review via GitHub when you are done.
ccarouge
left a comment
There was a problem hiding this comment.
A few things I missed. And where are the tests for read_optional_data?
|
Actually, can we rename |
8d37402 to
04c86bb
Compare
04c86bb to
b1514a5
Compare
ccarouge
left a comment
There was a problem hiding this comment.
It looks good. I'm requesting changes because of the fixtures for the tests but the other comments are minor.
1cad0c1 to
5b6c6fa
Compare
ccarouge
left a comment
There was a problem hiding this comment.
All good. A couple of simple suggestions.
90feba8 to
2efcd48
Compare
Fixes #234, #239
Merge Message
config.yamland fill all optional data before validation. We assume that using keys in config would never lead toKeyErrorin other modules after validation.multiprocessingtomultiprocessto match documentationwalltimeto match single digit numbers(?i)flag at the start formem