Skip to content

Add payu in benchcab conda environment#247

Merged
abhaasgoyal merged 3 commits intomainfrom
235-add-payu-conda-env
Jan 31, 2024
Merged

Add payu in benchcab conda environment#247
abhaasgoyal merged 3 commits intomainfrom
235-add-payu-conda-env

Conversation

@abhaasgoyal
Copy link
Copy Markdown

@abhaasgoyal abhaasgoyal commented Jan 29, 2024

Make current version of payu (1.1.2) compatible with building conda environment. Fixes #235

Merge Message

The following comment was used as a guideline for the changes:
payu-org/payu#413 (comment)

Further implications:

  • Since conda uses strict channel priority, packages from conda-forge take priority over packages defined in accessnri/coecms
  • coecms is used to build payu due to deploying yamanifest

@abhaasgoyal abhaasgoyal requested a review from ccarouge January 29, 2024 13:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e3ab664) 59.13% compared to head (47f050b) 59.13%.
Report is 20 commits behind head on main.

Files Patch % Lines
benchcab/benchcab.py 0.00% 4 Missing ⚠️
tests/test_config.py 97.36% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files          29       29           
  Lines        2129     2129           
=======================================
  Hits         1259     1259           
  Misses        870      870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhaasgoyal abhaasgoyal force-pushed the 235-add-payu-conda-env branch 2 times, most recently from b48574a to 7224c9e Compare January 29, 2024 13:48
@abhaasgoyal abhaasgoyal force-pushed the 235-add-payu-conda-env branch from 7224c9e to 78a9c86 Compare January 29, 2024 14:24
@abhaasgoyal abhaasgoyal changed the title Add payu in benchcab conda environment Add payu in benchcab conda environment Jan 29, 2024
@abhaasgoyal abhaasgoyal force-pushed the 235-add-payu-conda-env branch 2 times, most recently from 26b51fa to 42959c4 Compare January 30, 2024 01:35
@abhaasgoyal abhaasgoyal force-pushed the 235-add-payu-conda-env branch from 42959c4 to 3beb5e2 Compare January 30, 2024 02:53
Copy link
Copy Markdown
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhaasgoyal abhaasgoyal merged commit 77ea2ad into main Jan 31, 2024
@abhaasgoyal abhaasgoyal deleted the 235-add-payu-conda-env branch January 31, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add payu in the benchcab conda environment

2 participants