Add me.org met site configurations#27
Merged
SeanBryan51 merged 6 commits intomasterfrom Mar 15, 2023
Merged
Conversation
Assertion will fail anyway if the key does not exist.
- default met files based off the CABLE_multisite_PLUMBER experiment on modelevaluation.org - update unit tests for `met_subset` key - remove `get_all_met_sites()` - check default met files exist in `validate_environment()`
@gabsun has set up two experiments on modelevaluation.org to accept model output from CABLE: a five site test and a forty two site test. The user now specifies the `experiment` key in the config file which selects either to run with the five sites, the forty two sites, or a single site that is a subset of the five sites. Remove `met_subset` key from config file as met files are specified by the `experiment` key. For specifying met sites in each experiment, store only the site id internally for each met site and glob the `MET_DIR` directory to get the names of the corresponding met file. This way, when the met file data sets are updated, only the `MET_DIR` path needs to be updated. - check site ids map to valid files in `validate_environment()` Update unit tests for `check_config()`.
This was
linked to
issues
Mar 10, 2023
ccarouge
requested changes
Mar 10, 2023
ccarouge
reviewed
Mar 10, 2023
This change improves code readability (suggested by @ccarouge).
ccarouge
approved these changes
Mar 14, 2023
Member
ccarouge
left a comment
ccarouge
left a comment
There was a problem hiding this comment.
Ready to merge when you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow users to run a set of standard tests (experiments) for CABLE from which model output can be piped into modelevaluation.org. In particular we
This addresses issues #10 and #25.