Use TMPDIR environment variable instead of CWD#28
Merged
SeanBryan51 merged 1 commit intomasterfrom Mar 14, 2023
Merged
Conversation
Previously, pytest fails if the command is not run from the project root directory. This change uses the `TMPDIR` environment variable instead of `Path.cwd()` so that pytest runs correctly from any directory. Using `TMPDIR` has the added benefit that we won't run into permission issues if we run the tests on a central installation of benchcab. Fixes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
pytestfails if the command is not run from the project root directory. This change uses theTMPDIRenvironment variable instead ofPath.cwd()so thatpytestruns correctly from any directory.Using
TMPDIRhas the added benefit that we won't run into permission issues if we run the tests on a central installation ofbenchcab.Fixes #26