Conversation
This change modifies the behaviour so that when a science configuration file is not provided by the user, benchcab will default to using internally defined science configurations. Addresses issue #23
a59023c to
9e72a93
Compare
ccarouge
left a comment
There was a problem hiding this comment.
What is here is good. But I would add a global attribute to the netcdf output files. Maybe add the attribute "IS_DEFAULT_CONFIG" and the values could be: "DEFAULT_CONFIG_SET" or "CUSTOM_CONFIG_SET". Feel free to find better names/values.
I know the config is already listed but that's easier to see and find this way.
Yep we should do this for reproducibility reasons. However this made me realise, I think we should avoid having command line options that might effect the results of the test because:
So instead of specifying science configs as a command line argument, we add it to the config. What do you think? |
|
I agree, the more we can put in the |
This change lets the user provide an optional `science_configurations` key in config.yaml and removes the `science_config` command line option. This is to improve test reproducibility. See: #44 (comment) Fixes #42
| }, | ||
| "science_configurations": { | ||
| "sci0": { | ||
| "cable": { |
There was a problem hiding this comment.
Be careful! This breaks adjust_namelist_file for now since it expects the configs without the cable level. But leave it in since that's coming with the next PR.
Move science configurations from site_configs.yaml to config.yaml. This change is a part of CABLE-LSM/benchcab#44 Specify `cable` in the top level of each science config dictionary. This change is a part of CABLE-LSM/benchcab#48
Move science configurations from site_configs.yaml to config.yaml. This change is a part of CABLE-LSM/benchcab#44 Specify `cable` in the top level of each science config dictionary. This change is a part of CABLE-LSM/benchcab#48
This change modifies the behaviour so that when a science configuration file is not provided by the user,
benchcabwill default to using internally defined science configurations.Addresses issue #23