Polish standard output messages#69
Merged
SeanBryan51 merged 4 commits intomasterfrom May 17, 2023
Merged
Conversation
Collaborator
Author
|
Standard output from Captured stdout from job: |
Collaborator
Author
|
Standard out from Captured stdout from job: |
Currently, `benchcab` outputs stdout from other commands such as `svn` and `./build3.sh`, but does not output anything when running `./cable` or when generating particular directory structures. This commit improves the messages output to stdout by `benchcab` for all sub-commands. We also add a boolean flag to specify verbose output for each sub-command. Write the standard output from CABLE to the `tasks/<task_name>/out.txt` directory instead of writing to `/dev/null` so that it is accessible to the user. Fixes #67
SeanBryan51
force-pushed
the
67-polished-messaging-to-standard-output
branch
from
919e4de to
f8c12f0
Compare
Member
|
I've noticed this output in the build part: Do you know where it comes from? I don't see it happening for me. Just checking it is due to your setup and not a problem for users. |
Collaborator
Author
|
I think the error message is due to a custom conda environment being activated and so we cannot |
ccarouge
requested changes
May 10, 2023
|
|
||
| src_dir = Path(root_dir, internal.SRC_DIR) | ||
| if not src_dir.exists(): | ||
| print(f"Creating src directory: {src_dir}") |
Member
There was a problem hiding this comment.
Suggested change
| print(f"Creating src directory: {src_dir}") | |
| print(f"Creating {src_dir.relative_to(root_dir)} directory: {src_dir}") |
Should we replace all the relative path in the print statements like above? This means if we change the directory tree, we wouldn't have to change the printed messages.
| #PBS -P {project} | ||
| #PBS -j oe | ||
| #PBS -M {email_address} | ||
| #PBS -l storage=gdata/ks32+gdata/wd9+gdata/hh5+gdata/{project}+{curdir_root}/{curdir_proj} |
Member
There was a problem hiding this comment.
Suggested change
| #PBS -l storage=gdata/ks32+gdata/wd9+gdata/hh5+gdata/{project}+{curdir_root}/{curdir_proj} | |
| #PBS -l storage=gdata/ks32+gdata/hh5+gdata/{project}+{curdir_root}/{curdir_proj} |
Remove wd9 now if we change the formatting here
SeanBryan51
force-pushed
the
67-polished-messaging-to-standard-output
branch
from
dc668c7 to
7952f47
Compare
ccarouge
approved these changes
May 15, 2023
Add verbose standard output when compiling with a custom build script.
SeanBryan51
force-pushed
the
67-polished-messaging-to-standard-output
branch
from
f75ecb4 to
c1d5ef1
Compare
Member
|
- Add indentation to verbose output within running a task to improve stdout readability - Add blank line between steps of the workflow in all cases (verbose True/False) to improve stdout readability
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
benchcaboutputs stdout from other commands such assvnand./build3.sh, but does not output anything when running./cableor when generating particular directory structures.This commit improves the messages output to stdout by
benchcabfor all sub-commands. We also add a boolean flag to specify verbose output for each sub-command.Write the standard output from CABLE to the
tasks/<task_name>/out.txtdirectory instead of writing to/dev/nullso that it is accessible to the user.Remove
wd9dependence in source code.Fixes #67 and #64