Add ability to use branches of other users#82
Merged
SeanBryan51 merged 5 commits intomasterfrom May 31, 2023
Merged
Conversation
The user should be able to checkout branches of other users so that test suites can be reproduced by any user. This change lets the user specify the path relative to the SVN root of the CABLE repository for each branch by specifying the `path` key in the configuration file. Remove the `trunk` and `share_branch` keys from the configuration file as this information is contained within `path`. This change repurposes the `name` key for each branch to be an alias used internally by benchcab. This lets the user specify the directory name when checking out the branch, that is, `name` is the optional `PATH` argument to svn checkout`. This is useful in the case that we have a collision in branch names when checking out multiple branches. Remove the `-M` PBS argument for sending emails in the job script as the default behaviour is sufficient. Remove the `user` key as this is now redundant. Update unit tests for `check_config()`. Fixes #61
SeanBryan51
added a commit
to CABLE-LSM/bench_example
that referenced
this pull request
May 18, 2023
Changes a part of: CABLE-LSM/benchcab#82
This was referenced May 18, 2023
Collaborator
Author
|
TODO
|
ccarouge
requested changes
May 18, 2023
Member
ccarouge
left a comment
ccarouge
left a comment
There was a problem hiding this comment.
That's good. But you forgot to update the documentation.
| #PBS -q normal | ||
| #PBS -P {project} | ||
| #PBS -j oe | ||
| #PBS -M {email_address} |
Member
There was a problem hiding this comment.
Instead should we have:
#PBS -m e
This will send an email at completion of the script whether it succeeds or fails.
Member
|
Do we want to make |
Send email to user by default when job terminates.
Specifying the `name` as an alias is only useful when we have a name collision between branches which is rare. By default, set the `name` key to be the base name of the `path` key.
SeanBryan51
added a commit
to CABLE-LSM/bench_example
that referenced
this pull request
May 19, 2023
Changes a part of: CABLE-LSM/benchcab#82
ccarouge
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user should be able to checkout branches of other users so that test suites can be reproduced by any user.
This change lets the user specify the path relative to the SVN root of the CABLE repository for each branch by specifying the
pathkey in the configuration file. Remove thetrunkandshare_branchkeys from the configuration file as this information is contained withinpath.This change repurposes the
namekey for each branch to be an alias used internally by benchcab. This lets the user specify the directory name when checking out the branch, that is,nameis the optionalPATHargument to svn checkout`. This is useful in the case that we have a collision in branch names when checking out multiple branches.Remove the
-MPBS argument for sending emails in the job script as the default behaviour is sufficient.Remove the
userkey as this is now redundant.Update unit tests for
check_config().Fixes #61