Upgrade uxarray to 2025.12.0 and bug fixes#4
Merged
Conversation
kjnam
approved these changes
Feb 10, 2026
added 3 commits
February 10, 2026 16:52
In SxDataArray constructor, pop incoming uxgrid from kwargs and assign to sxgrid before calling super().__init__. This prevents isel (and potentially other paths leading to UxDataArray/SxDataArray reconstructions) from passing uxgrid in kwargs and causing multiple-value errors.
…ame_coords to address issues with uxarray uxarray's _read_ugrid function does not properly rename nSCHISM_hgrid_edge dimension to n_edge anymore. Added temporary path to rename this dimension (and n_face and n_node for future) on our side when _read_schism_grid is called. Fixes failing test_integrate_nodal.
kjnam
force-pushed
the
uxarray-upgrade-branch
branch
from
617c303 to
4fd23b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the uxarray dependency from 2025.6.0 to 2025.12.0.
Bugfix: In SxDataArray.init pop uxgrid from kwargs (if present) and assign it to sxgrid so the parent UxDataArray reconstruction paths (e.g., isel) no longer produce multiple-value/type errors.
Bugfix: in _schismgrid._rename_coords add checks to rename SCHISM dimensions to n_edge, n_face, n_node as uxarray.io._read_ugrid does not consistently rename dimensions.