CAF-3876: Extracted required classes to a lib project#18
Merged
Anthony-McGreevy merged 3 commits intodevelopfrom Jan 8, 2018
Merged
CAF-3876: Extracted required classes to a lib project#18Anthony-McGreevy merged 3 commits intodevelopfrom
Anthony-McGreevy merged 3 commits intodevelopfrom
Conversation
Contributor
Author
mmaBel
suggested changes
Jan 8, 2018
Contributor
mmaBel
left a comment
mmaBel
left a comment
There was a problem hiding this comment.
Update the main README with a description of the worker-document-lib project.
I'm not sold on lib being a great name, lib is very generic and could apply to worker-document itself. It's not much better but these are classes that serve utility purposes (allowing passing document without danger of it being modified) so worker-document-util?
| @@ -0,0 +1 @@ | |||
| com.hpe.caf.worker.document.DocumentWorkerFactoryProvider | |||
Contributor
There was a problem hiding this comment.
Why is this here? The worker-document project has this file and DocumentWorkerFactoryProvider isn't in worker-document-lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.