Fix BKT params naming: use defaultBKTParams and experimentalBKTParams#109
Merged
mjyang00001 merged 1 commit intoCAHLR:content-stagingfrom Apr 10, 2026
Merged
Conversation
- Update workflow to create defaultBKTParams.json and experimentalBKTParams.json - Update App.js imports to use new filenames - Fixes module not found error for bktParams1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-content-staging.ymlto generatedefaultBKTParams.jsonandexperimentalBKTParams.jsoninstead ofbktParams1.json/bktParams2.jsonApp.jsimports to match the new filenamesWhy
The incremental update workflow was generating files with the new names (
defaultBKTParams/experimentalBKTParams) butcontent-staging'sApp.jswas still importing the old names (bktParams1/bktParams2). This caused the build to silently fall back to stale BKT params, resulting in BKT parameter console errors and lessons not rendering correctly.This fix was originally made on
fix-bktparams-for-content-staging(commit 4d11d9d) but was never merged intocontent-staging.Test plan