Skip to content

Conversation

@lawhead
Copy link
Collaborator

@lawhead lawhead commented Sep 17, 2021

Overview

Fix a bug in the task helper get_key_press method introduced by recent changes to the experiment clock.

Ticket

https://www.pivotaltracker.com/story/show/179628895

Contributions

  • Refactored get_key_press to convert the timestamp after it is retrieved from psychopy.

Test

  • Run Copy Phrase with the Inquiry Preview feature. The keypress should not throw an exception. The stamp associated with the keypress in the triggers.txt file should have a value greater than the preceding inquiry_preview trigger and less than the fixation trigger.

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here.

@lawhead lawhead requested a review from tab-cmd September 17, 2021 23:28
@lawhead lawhead changed the base branch from main to 1.5.1 September 17, 2021 23:29
@lawhead lawhead merged commit 41c154a into 1.5.1 Sep 20, 2021
@lawhead lawhead deleted the keypress-clock-fix branch September 20, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants