Make build excluded over all folders in the project #29
Conversation
|
@henrikbrixandersen Interestingly you will not be putted as assignee. Thus I ping you :) Please take a look. |
There is really no need to ping me. I get notifications for all activity here. |
| # build | ||
| /build* | ||
| *build* | ||
| /twister-out* |
There was a problem hiding this comment.
The *build* glob is a little too wide IMO. Please remove the existing /build* glob add a **/build* glob at the end of the # build section instead.
There was a problem hiding this comment.
@henrikbrixandersen Hi, glad to see you working on weekend :) Thank you pointing on it. It is done in the commit: 2a39694
KozhinovAlexander
force-pushed
the
fix_build_git_exclude
branch
from
088a30e to
2a39694
Compare
Current /build* ignore pattern will exclude build only in the root of the project. In some cases it is needed build folder to be located in app folder or anywhere else in the project. This PR fixes this behaviour. Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
.gitignore
Outdated
|
|
||
| # build | ||
| /build* | ||
| **/build* |
There was a problem hiding this comment.
Thanks. Please move it to after the /twister-out* line as well.
There was a problem hiding this comment.
You were faster than me. It is done now here: c19fab3
KozhinovAlexander
force-pushed
the
fix_build_git_exclude
branch
from
2a39694 to
c19fab3
Compare
|
@KozhinovAlexander Thank you for your contribution :) |
2 participants
Current /build* ignore pattern will exclude build only in the root of the project.
In some cases it is needed build folder to be located in app folder or anywhere else in the project.
This PR fixes this behaviour.
How to reporduce: Make west put build artefacts into /app/build folder or just move your folder there. You shall see git showing you about 500 untracked files.
UPDATE: This change allows efectivelly delete the whole build folder with
git clean -xdf. Please still be carefull using this command anyway.