Fix swapped image ICD test crash on macOS 15#81
Merged
Conversation
pshnghng0318
approved these changes
May 15, 2026
| @@ -584,7 +584,6 @@ describe('OPEN_SWAPPED_IMAGES test: Testing open swapped images in different axe | |||
| expect(RasterTileData.length).toEqual(assertItem.addTilesReq[2].tiles.length + 2); | |||
| expect(RasterTileData.slice(-1)[0].endSync).toEqual(true); | |||
| msgController.setSpatialRequirements(assertItem.setSpatialRequirements[3]); | |||
Contributor
There was a problem hiding this comment.
It seems that currently three command setSpatialRequirements sequently or concurrently may cause the backend crash. It is fine to remove one of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #80. It appears that three consecutive spatial profile requests cause the backend to crash. This issue only occurs on the macOS 15 ICD server, and the root cause is still unclear.
Since these spatial profile requests are not the primary focus of the swapped image tests, and there are currently no validations for the returned spatial profiles, I removed one of them to allow the tests to run smoothly and consistently.
Checklist
For the pull request:
Documentation has been updated(or no documentation changes are needed)