Merged
Conversation
HendersonSC
reviewed
Mar 5, 2021
Contributor
There was a problem hiding this comment.
Okay...I am hard pressed to say this looks good, but that is more a statement to the limitations of adding such features than the actual code. Left a few comments in the unit test, they are in no way really limiting and due to the size of the unit test might be better to spin off into a separate issue.
HendersonSC
approved these changes
Mar 5, 2021
Author
|
Only test failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for 5D, 6D, and 7D ints and reals in parameter lists with testing. Also adds support to read and write said datasets as part of a parameter list in the HDF5 file.