fix: improve UX, security, and iTerm2 compatibility#6
Merged
Conversation
Santa Method review identified and fixed user interaction issues: - Mask API key input with term.ReadPassword() during setup - Fix error color from yellow to red, eliminate double error display - Add NO_COLOR/TERM=dumb/non-tty detection for all ANSI output - Replace 200ms daemon start sleep with exponential-backoff socket polling - Add root command Long help text explaining primary usage pattern - Pass detected terminal width to markdown renderer - Unify success message formatting with render.Green()/render.Red() Fix iTerm2 (and other terminal) compatibility: - Replace glamour.WithAutoStyle() which sends an OSC 11 query that blocks for 5 seconds when the terminal doesn't respond. Use GLAMOUR_STYLE/COLORFGBG env vars instead, defaulting to dark. - Enable kitty keyboard protocol in zle-line-init/zle-line-finish hooks so Shift+Enter works automatically in iTerm2 3.5+, kitty, WezTerm, foot, and Ghostty without manual terminal configuration. - Fix README to accurately describe terminal support (was claiming auto-detection that didn't exist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inline-cli setupwithterm.ReadPassword()glamour.WithAutoStyle()OSC 11 query (5s hang) with env-var-based style detectionzle-line-init/zle-line-finishhooks so Shift+Enter works automatically in iTerm2 3.5+, kitty, WezTerm, foot, GhosttyTest plan
go build ./...passesgo test -race ./...passes (including newisDarkFromCOLORFGBGand no-hang tests)go vet ./...cleanNO_COLOR=1 inline-cli query ...produces no ANSI escapes