Skip to content

test: add 50 unit tests for loading and processing data#53

Open
bianjh-cloud wants to merge 8 commits intomainfrom
50-unit-tests-for-loading-and-processing-data
Open

test: add 50 unit tests for loading and processing data#53
bianjh-cloud wants to merge 8 commits intomainfrom
50-unit-tests-for-loading-and-processing-data

Conversation

@bianjh-cloud
Copy link
Copy Markdown
Collaborator

Changes

Functions Tested

  • add_VDJ_metadata() - VDJ metadata integration
  • convert_human_gene_list() - Human to mouse gene list conversion
  • run_batch_correction() - Batch correction workflows
  • run_AUCell() - AUCell scoring
  • filter_doublets() - Doublet filtering

Changes

  • Added 5 new test files covering unit tests for each function
  • Added test fixture: BRCA downsampled Seurat object
  • Added helper functions for test data setup and selection
  • Included celldex reference cache for reproducible tests

Test Data

Tests use the downsampled BRCA dataset (BRCA_Combine_and_Renormalize_SO_downsample.rds) and helper functions for loading plain and processed PBMC data.

Issues

#50

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • Run devtools::check() locally and fix all notes, warnings, and errors.
  • R-CMD-check succeeds on the most recent user commit.

@bianjh-cloud bianjh-cloud linked an issue Apr 22, 2026 that may be closed by this pull request
@github-actions github-actions Bot added the SCOT RepoName label Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.02%. Comparing base (3d43595) to head (ea1da66).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
+ Coverage   17.56%   46.02%   +28.45%     
===========================================
  Files          21       21               
  Lines         814      830       +16     
===========================================
+ Hits          143      382      +239     
+ Misses        671      448      -223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bianjh-cloud
Copy link
Copy Markdown
Collaborator Author

bianjh-cloud commented Apr 22, 2026

Error: Error: R CMD check found WARNINGs
Execution halted
'::' or ':::' import not declared from: ‘stringr’

Fixed: updated DESCRIPTIONS to include stringr

@kelly-sovacool kelly-sovacool changed the title 50 unit tests for loading and processing data test: add 50 unit tests for loading and processing data Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCOT RepoName

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit Tests for Loading and Processing Data

2 participants