Skip to content

Conversation

@bigharshrag
Copy link
Contributor

Added Cyrillic support (Cyrillic-1, Cyrillic-2, Cyrillic-3 character sets) for teletext which had earlier been missing which resolves #283 .

@cfsmp3 cfsmp3 merged commit d249b1c into CCExtractor:master Mar 13, 2016
@bigharshrag bigharshrag deleted the Cyrilic_Support branch March 14, 2016 09:37
@bigharshrag bigharshrag restored the Cyrilic_Support branch March 14, 2016 10:51
@bigharshrag bigharshrag deleted the Cyrilic_Support branch March 15, 2016 11:04
@abhishek-vinjamoori
Copy link
Contributor

    // Now we have the begining of page transmission; if there is page_buffer pending, process it
    if (ctx->page_buffer.tainted == YES)
    {
        // Convert telx to UCS-2 before processing
        for(uint8_t yt = 1; yt <= 23; ++yt)
        {
            for(uint8_t it = 0; it < 40; it++)
            {
                if (ctx->page_buffer.text[yt][it] != 0x00)
                    ctx->page_buffer.text[yt][it] = telx_to_ucs2(ctx->page_buffer.text[yt][it]);
            }
        }

Can I know why this is being done before ?
It is causing some issues, for fixing other bugs. When special cases are being handled, this causes over-writing.

@bigharshrag
Copy link
Contributor Author

When dealing with character sets other than the Latin G0 character set, the X/28 packet may be received after the data from the X/1 to X/25. The X/28 (or M/29) contain data regarding the default character sets. Since it was earlier being converted to UCS-2 as soon as we received data from X/1 to X/25, Latin data was being written for the first time, after which it switched to the new G0 character set. This simply delays conversion from telx to UCS-2 until data about default G0 character set is received.

Could you please share what issues this is causing. Please share the related sample files as well.

hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
- We have the similar function at multiple places serving the same purpose.
- It is made available in the utility module and can be accessed anywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cyrilic support. Missing or broken.

3 participants