feat: add datetime picker for start field in TaskDialog #349
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hell1213
left a comment
Hell1213
left a comment
There was a problem hiding this comment.
Replaced the basic date picker with a datetime picker for the start field in task editing. Now users can pick both date and time instead of just date, and it handles the formats properly on both frontend and backend.
backend/controllers/edit_task.go
Outdated
| return | ||
| } | ||
|
|
||
| startFormatted, err := utils.ConvertISOToTaskwarriorFormat(start) |
There was a problem hiding this comment.
this should be just start
There was a problem hiding this comment.
thanks , will resolve this immediately .
Hell1213
force-pushed
the
add-datetime-picker-start-field
branch
from
62d2d4b to
3953310
Compare
its-me-abhishek
changed the title
|
Please follow the commit conventions as set in CONTRIBUTING.MD while naming PRs and commits |
2 participants
Added datetime picker for the start field in task edit dialog. Users can now select both date and time when editing the start field of existing tasks.
Contributes: #326
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
When users select only a date, it saves as YYYY-MM-DD format. When they select date + time, it saves as ISO format. No random time is added when users only pick a date.